Attention is currently required from: laforge, pespin.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32653?usp=email )

Change subject: nanoBTS: print [supported] versions of MOs ......................................................................

Patch Set 1:

(2 comments)

Patchset:

PS1: Somehow I forgot that I reviewed this patch back in May, and submitted my own patch doing the same thing (plus storing the version): https://gerrit.osmocom.org/c/osmo-bsc/+/34356, which has been merged recently. What can be still taken from this patch is printing the additional MO versions (my patch is printing the first one only).

File src/osmo-bsc/bts_ipaccess_nanobts.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/32653/comment/95236b9d_cd6f2b14 PS1, Line 222: if (!is_ipa_abisip_bts(bts))

Ack

Actually, this check does make sense. This function is called from a signal handler (`SS_NM`), and the signal itself is sent from the generic OML logic whenever the `Software Activated Report` is received from *some* BTS, which is not necessarily a nanoBTS or osmo-bts. But the ordering point remains: there should be no code preceding this check.

I just pushed a patch adding the missing checks to other functions in this file:

https://gerrit.osmocom.org/c/osmo-bsc/+/34454