Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/29514 )
Change subject: osmux: Fix AMR F,Q,CMR fields not properly encoded in osmux header
......................................................................
Patch Set 1:
(2 comments)
File src/osmux.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-netif-lint-90):
https://gerrit.osmocom.org/c/libosmo-netif/+/29514/comment/cecd1dcc_125a1cc6
PS1, Line 392: batch->osmuxh->amr_q= state->amrh->q;
spaces required around that '=' (ctx:VxW)
File tests/osmux/osmux_input_test.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-netif-lint-90):
https://gerrit.osmocom.org/c/libosmo-netif/+/29514/comment/6114d874_78f7c830
PS1, Line 289: printf("===%s===\n", __FUNCTION__);
__func__ should be used instead of gcc specific __FUNCTION__
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-netif/+/29514
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I06f3d07a05181d938c22bbd0da7172b5dad6659a
Gerrit-Change-Number: 29514
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Wed, 28 Sep 2022 17:05:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment