[S] Change in osmo-bts[master]: osmo-bts-trx: trx_fn_timer_cb(): fix misleading shutdown reason - gerrit-log

25 Apr 2025

Attention is currently required from: pespin.

fixeria has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/osmo-bts/+/40156?usp=email )

Change subject: osmo-bts-trx: trx_fn_timer_cb(): fix misleading shutdown reason
......................................................................

Patch Set 3:

(2 comments)

File src/osmo-bts-trx/scheduler_trx.c:

https://gerrit.osmocom.org/c/osmo-bts/+/40156/comment/c20767e1_e97d25c4?usp… :
PS2, Line 414: 	const char *reason;
...
  better NULL it here to avoid some mess in the future
if someone changes some code path. Acknowledged

https://gerrit.osmocom.org/c/osmo-bts/+/40156/comment/3e6d76a4_88c30004?usp… :
PS2, Line 454: 		reason = "PC clock skew";
...
  I'd rather change this to something like "PC
clock skew too high". […] Acknowledged

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/40156?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ibbbbc4e919e6eb812882fc60de4be13fa77934b7
Gerrit-Change-Number: 40156
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Comment-Date: Fri, 25 Apr 2025 14:53:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;