Attention is currently required from: pespin.

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/40156?usp=email )

Change subject: osmo-bts-trx: trx_fn_timer_cb(): fix misleading shutdown reason ......................................................................

Patch Set 3:

(2 comments)

File src/osmo-bts-trx/scheduler_trx.c:

https://gerrit.osmocom.org/c/osmo-bts/+/40156/comment/c20767e1_e97d25c4?usp=... : PS2, Line 414: const char *reason;

better NULL it here to avoid some mess in the future if someone changes some code path.

Acknowledged

https://gerrit.osmocom.org/c/osmo-bts/+/40156/comment/3e6d76a4_88c30004?usp=... : PS2, Line 454: reason = "PC clock skew";

I'd rather change this to something like "PC clock skew too high". […]

Acknowledged