Attention is currently required from: pespin, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31341 )

Change subject: pcu_l1_if_phy: flexible phy access ......................................................................

Patch Set 7:

(1 comment)

Patchset:

PS7: Thanks for your review comments Pau, this is really helpful.

I think there is some misconception about the ops callbacks l1if_open_pdch, l1if_connect_pdch, l1if_pdch_req and l1if_close_pdch. All four must be present. They are mandatory for the driver to work. I have added OSMO_ASSERTs to make sure they are defined. So it is safe to check only the_pcu->phy_ops.