Attention is currently required from: pespin, fixeria.
View Change
1 comment:
Patchset:
Patch Set #7:
Thanks for your review comments Pau, this is really helpful.
I think there is some misconception about the ops callbacks l1if_open_pdch, l1if_connect_pdch, l1if_pdch_req and l1if_close_pdch. All four must be present. They are mandatory for the driver to work. I have added OSMO_ASSERTs to make sure they are defined. So it is safe to check only the_pcu->phy_ops.
To view, visit change 31341. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I8692d1bd5d137a17cf596ee2914722f419c9978d
Gerrit-Change-Number: 31341
Gerrit-PatchSet: 7
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Thu, 16 Feb 2023 16:29:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment