Attention is currently required from: fixeria, lynxis lazus, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34742?usp=email )
Change subject: osmo_epdg_app: Fix formatting error in log string
......................................................................
Patch Set 1:
(1 comment)
File src/osmo_epdg_app.erl:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34742/comment/fbda929f_d2ad9...
PS1, Line 8: ~n
From https://riak.com/posts/technical/introducing-lager-a-new-logging-framework-f...
Also notice that you don’t need to stick a newline on the end of the log message. Lager automatically (and happily) does that for you.
--
To view, visit
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34742?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: Ib8dfa40ad028f959e4816ce5056ff64d52ec647b
Gerrit-Change-Number: 34742
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: lynxis lazus
lynxis@fe80.eu
Gerrit-CC: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: lynxis lazus
lynxis@fe80.eu
Gerrit-Comment-Date: Tue, 17 Oct 2023 11:20:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Gerrit-MessageType: comment