pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29376 )
Change subject: ipacces-config: override gsm_bts_check_cfg() to void checking unset bts configuration ......................................................................
ipacces-config: override gsm_bts_check_cfg() to void checking unset bts configuration
the shared code in libbsc checks for sane config being set, but this doesn't really apply to ipaccess-config, wihich doesn't set such config fields internally.
Change-Id: I22ff0d22d6dcf9b0f715bfa4e0daeb52c4028308 --- M src/ipaccess/stubs.c M src/osmo-bsc/bts.c 2 files changed, 7 insertions(+), 1 deletion(-)
Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified
diff --git a/src/ipaccess/stubs.c b/src/ipaccess/stubs.c index 60fa626..aaec4c5 100644 --- a/src/ipaccess/stubs.c +++ b/src/ipaccess/stubs.c @@ -30,3 +30,9 @@ /* No TS init required here. */ return true; } + +int gsm_bts_check_cfg(struct gsm_bts *bts) +{ + /* No checks required here */ + return 0; +} diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 95e7430..b7d3c3c 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -461,7 +461,7 @@ }
/* Validate BTS configuration (ARFCN settings and physical channel configuration) */ -int gsm_bts_check_cfg(struct gsm_bts *bts) +__attribute__((weak)) int gsm_bts_check_cfg(struct gsm_bts *bts) { struct gsm_bts_trx *trx;