fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29539 )

Change subject: fix pcu_l1if_tx_ptcch(): do not send empty blocks to GSMTAP ......................................................................

fix pcu_l1if_tx_ptcch(): do not send empty blocks to GSMTAP

This makes no sense and confuses Wireshark, so it shows malformed packets. We are not sending empty PDTCH blocks to GSMTAP either.

Change-Id: Ic7b6aca4f3af43a6fd47d033c950c711164685a4 Related: SYS#6045 --- M src/pcu_l1_if.cpp 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/39/29539/1

diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp index 221a1f7..67e4de5 100644 --- a/src/pcu_l1_if.cpp +++ b/src/pcu_l1_if.cpp @@ -244,7 +244,7 @@ uint32_t fn, uint8_t block_nr, uint8_t *data, size_t data_len) { - if (the_pcu->gsmtap_categ_mask & (1 << PCU_GSMTAP_C_DL_PTCCH)) + if (data_len && the_pcu->gsmtap_categ_mask & (1 << PCU_GSMTAP_C_DL_PTCCH)) gsmtap_send(the_pcu->gsmtap, arfcn, ts, GSMTAP_CHANNEL_PTCCH, 0, fn, 0, 0, data, data_len); #ifdef ENABLE_DIRECT_PHY if (bts->trx[trx].fl1h) {