Attention is currently required from: tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/36653?usp=email ) Change subject: iCE1usb: Add support to configure CRC4 mode for TX/RX ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File src/vty.c: https://gerrit.osmocom.org/c/osmo-e1d/+/36653/comment/b6db3d53_7ebb7f0c PS1, Line 434: framing-tx (no-crc4|crc4)", indeed, there are a lot of constraints in the possible/accepted VTY syntax. File src/vty.c: https://gerrit.osmocom.org/c/osmo-e1d/+/36653/comment/6c0146b8_8f41ed33 PS2, Line 465: if (line->intf->drv == E1_DRIVER_USB) { one could check if rx == tx and then use just the "framing" command -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/36653?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I9b627a9617af4ae9ed98214d672c7d0391f801eb Gerrit-Change-Number: 36653 Gerrit-PatchSet: 2 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Mon, 29 Apr 2024 19:40:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: tnt <tnt(a)246tNt.com> Gerrit-MessageType: comment