Attention is currently required from: tnt.

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/36653?usp=email )

Change subject: iCE1usb: Add support to configure CRC4 mode for TX/RX ......................................................................

Patch Set 2: Code-Review+1

(2 comments)

File src/vty.c:

https://gerrit.osmocom.org/c/osmo-e1d/+/36653/comment/b6db3d53_7ebb7f0c PS1, Line 434: framing-tx (no-crc4|crc4)",

Done

indeed, there are a lot of constraints in the possible/accepted VTY syntax.

File src/vty.c:

https://gerrit.osmocom.org/c/osmo-e1d/+/36653/comment/6c0146b8_8f41ed33 PS2, Line 465: if (line->intf->drv == E1_DRIVER_USB) { one could check if rx == tx and then use just the "framing" command