Attention is currently required from: pespin.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/29364
)
Change subject: oml: Delay Tx of OPSTART(BBTRANSC) after rx of RSL CONNECT ACK
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File src/osmo-bsc/bts_ipaccess_nanobts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/29364/comment/4aa65602_a5d8e33a
PS1, Line 453: LOGPFOH(DNM, LOGL_ERROR, foh, "IPACC RSL Connect ACK received on
incorrect object class %d!\n", foh->obj_class);
(log string of object class? same below)
File src/osmo-bsc/nm_bb_transc_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/29364/comment/0107666e_aa660aa2
PS1, Line 254: bb_transc->mo.opstart_sent = false;
(patch would look nicer without move of this line)
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/29364
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ief46bad5075b656c13d1f09a0724e33283148236
Gerrit-Change-Number: 29364
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 19 Sep 2022 12:48:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment