Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39023?usp=email ) Change subject: rspro: use osmo_stream to handle IPA connection ...................................................................... Patch Set 6: Code-Review+1 (2 comments) File src/rspro_client_fsm.c: https://gerrit.osmocom.org/c/osmo-remsim/+/39023/comment/5c1fb954_b8edd3af?… : PS6, Line 174: _ipaccess_bts_handle_ccm It's not the first time I am seeing this (or similar) code. Can we have it in a library somewhere? https://gerrit.osmocom.org/c/osmo-remsim/+/39023/comment/58a99e96_35190fe6?… : PS6, Line 226: if (res <= 0) { Is it safe to call `osmo_ipa_msgb_cb_proto()` before this check? -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39023?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I9cba48bf8eba85215acef70eda7bcf8ec13ea49a Gerrit-Change-Number: 39023 Gerrit-PatchSet: 6 Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Comment-Date: Thu, 05 Dec 2024 19:20:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes