pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28216 ) Change subject: nm_*_fsm: Remove comment no longer applying ...................................................................... nm_*_fsm: Remove comment no longer applying Since b7ef6884f91db7ffe7add51766abc311c9e7d05e, the state is updated before triggering the signal S_NM_STATECHG, so the warning does no longer hold true. Change-Id: I7b7dd30b4fcdc92febca42e3e6a75e6f98e184ff --- M src/osmo-bsc/nm_bb_transc_fsm.c M src/osmo-bsc/nm_bts_fsm.c M src/osmo-bsc/nm_channel_fsm.c M src/osmo-bsc/nm_gprs_cell_fsm.c M src/osmo-bsc/nm_gprs_nse_fsm.c M src/osmo-bsc/nm_gprs_nsvc_fsm.c M src/osmo-bsc/nm_rcarrier_fsm.c 7 files changed, 0 insertions(+), 14 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/nm_bb_transc_fsm.c b/src/osmo-bsc/nm_bb_transc_fsm.c index 9572377..bf24691 100644 --- a/src/osmo-bsc/nm_bb_transc_fsm.c +++ b/src/osmo-bsc/nm_bb_transc_fsm.c @@ -191,8 +191,6 @@ { struct gsm_bts_bb_trx *bb_transc = (struct gsm_bts_bb_trx *)fi->priv; - /* Warning: In here we may be acessing an state older than new_state - from prev (syncrhonous) FSM state */ configure_loop(bb_transc, &bb_transc->mo.nm_state, true); } diff --git a/src/osmo-bsc/nm_bts_fsm.c b/src/osmo-bsc/nm_bts_fsm.c index 79ae6a7..1b71323 100644 --- a/src/osmo-bsc/nm_bts_fsm.c +++ b/src/osmo-bsc/nm_bts_fsm.c @@ -207,8 +207,6 @@ { struct gsm_bts *bts = (struct gsm_bts *)fi->priv; - /* Warning: In here we may be acessing an state older than new_state - from prev (syncrhonous) FSM state */ configure_loop(bts, &bts->mo.nm_state, true); } diff --git a/src/osmo-bsc/nm_channel_fsm.c b/src/osmo-bsc/nm_channel_fsm.c index 680e658..c3146a4 100644 --- a/src/osmo-bsc/nm_channel_fsm.c +++ b/src/osmo-bsc/nm_channel_fsm.c @@ -168,8 +168,6 @@ { struct gsm_bts_trx_ts *ts = (struct gsm_bts_trx_ts *)fi->priv; - /* Warning: In here we may be acessing an state older than new_state - from prev (syncrhonous) FSM state */ configure_loop(ts, &ts->mo.nm_state, true); } diff --git a/src/osmo-bsc/nm_gprs_cell_fsm.c b/src/osmo-bsc/nm_gprs_cell_fsm.c index 9a656e1..aabfc0b 100644 --- a/src/osmo-bsc/nm_gprs_cell_fsm.c +++ b/src/osmo-bsc/nm_gprs_cell_fsm.c @@ -178,8 +178,6 @@ { struct gsm_gprs_cell *cell = (struct gsm_gprs_cell *)fi->priv; - /* Warning: In here we may be acessing an state older than new_state - from prev (syncrhonous) FSM state */ configure_loop(cell, &cell->mo.nm_state, true); } diff --git a/src/osmo-bsc/nm_gprs_nse_fsm.c b/src/osmo-bsc/nm_gprs_nse_fsm.c index 4ad623e..49908ce 100644 --- a/src/osmo-bsc/nm_gprs_nse_fsm.c +++ b/src/osmo-bsc/nm_gprs_nse_fsm.c @@ -179,8 +179,6 @@ { struct gsm_gprs_nse *nse = (struct gsm_gprs_nse *)fi->priv; - /* Warning: In here we may be acessing an state older than new_state - from prev (syncrhonous) FSM state */ configure_loop(nse, &nse->mo.nm_state, true); } diff --git a/src/osmo-bsc/nm_gprs_nsvc_fsm.c b/src/osmo-bsc/nm_gprs_nsvc_fsm.c index 75cf4d6..29eed5c 100644 --- a/src/osmo-bsc/nm_gprs_nsvc_fsm.c +++ b/src/osmo-bsc/nm_gprs_nsvc_fsm.c @@ -194,8 +194,6 @@ { struct gsm_gprs_nsvc *nsvc = (struct gsm_gprs_nsvc *)fi->priv; - /* Warning: In here we may be acessing an state older than new_state - from prev (syncrhonous) FSM state */ configure_loop(nsvc, &nsvc->mo.nm_state, true); } diff --git a/src/osmo-bsc/nm_rcarrier_fsm.c b/src/osmo-bsc/nm_rcarrier_fsm.c index 657abea..fbd3179 100644 --- a/src/osmo-bsc/nm_rcarrier_fsm.c +++ b/src/osmo-bsc/nm_rcarrier_fsm.c @@ -184,8 +184,6 @@ { struct gsm_bts_trx *trx = (struct gsm_bts_trx *)fi->priv; - /* Warning: In here we may be acessing an state older than new_state - from prev (syncrhonous) FSM state */ configure_loop(trx, &trx->mo.nm_state, true); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28216 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7b7dd30b4fcdc92febca42e3e6a75e6f98e184ff Gerrit-Change-Number: 28216 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged