Attention is currently required from: fixeria, laforge, pespin.

csaba.sipos has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email )

Change subject: nokia_site: Add object_identity, object_state and object_identity_state attributes ......................................................................

Patch Set 10:

(3 comments)

Patchset:

PS9:

I'm sorry to keep delaying merge of this, but I ask for simpel changes sometimes and then new versio […]

Apologies for that, but besides what you asked for, we also found an unhandled situation: the OBJ_ID_STATE was checked in the previous version for protocol compliance, but it was not mapped in case that message arrived instead of object_id + object_state. This last version fixed that.

File src/osmo-bsc/bts_nokia_site.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/17172ad2_c6a24e5a?usp=... : PS9, Line 1857: if (find_element(noh->data, len_data, NOKIA_EI_OBJ_ID, object_identity, sizeof(object_identity)) != sizeof(object_identity) ||

This is now tons of lines >120 chars (the maximum as per osmocom guidelines) and becomes unreadable […]

I fixed those lines (but it is even less readable now).

The reason for the convoluted if/else system is the protocol itself. There are some mandatory cross-dependent elements some optional cross-dependent elements, and they have to go to the same LOG_BTS lines eventually. To make this compact (instead of using even more if..else), this was the chosen solution.

https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/26f85298_b6ffd30f?usp=... : PS9, Line 1858: find_element(noh->data, len_data, NOKIA_EI_OBJ_STATE, &object_state, sizeof(object_state)) != sizeof(object_state)) {

this is not properly aligned to the line above.

Acknowledged