Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-remsim/+/39132?usp=email )
Change subject: Several logging improvements
......................................................................
Patch Set 1:
(2 comments)
File src/bankd/bankd_main.c:
https://gerrit.osmocom.org/c/osmo-remsim/+/39132/comment/a777f498_c830f25d?… :
PS1, Line 429: fprintf(stderr, "ERROR: reading PCSC slots\n");
this s ounds like it's an error related to the PC/SC driver. In reality it's an
error reading a CSV file mapping PC/SC slots to internal slot numbers. The message should
refer to the CSV file, IMHO.
File src/server/rspro_server.c:
https://gerrit.osmocom.org/c/osmo-remsim/+/39132/comment/e7f35e46_2ac5a4c6?… :
PS1, Line 784: ,
I'd say this is DEBUG level.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-remsim/+/39132?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I4fa91ca8c8e576094d3a9598df5ad96b230bbde0
Gerrit-Change-Number: 39132
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 12 Dec 2024 18:59:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No