[L] Change in osmo-pcap[master]: server: Support storing of pcapng format - gerrit-log

13 Jan 2025


      Attention is currently required from: daniel, laforge, pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39287?usp=email )
Change subject: server: Support storing of pcapng format
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File src/osmo_server_network.c:
https://gerrit.osmocom.org/c/osmo-pcap/+/39287/comment/88bddc0e_34f4ae1a?usp... :
PS4, Line 314: 	"The recvd pcap_file_header contains too big snaplen %zu > %zu\n",
             : 		(size_t) hdr->snaplen, (size_t) conn->server->max_snaplen);
missing indentation
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39287?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: I275d28ab418a1514fa9c5c7c20f3d831cc6af8bb
Gerrit-Change-Number: 39287
Gerrit-PatchSet: 4
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel dwillmann@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: daniel dwillmann@sysmocom.de
Gerrit-Comment-Date: Mon, 13 Jan 2025 15:58:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes