Attention is currently required from: lynxis lazus, pespin.

Hoernchen has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174?usp=email )

Change subject: dfu: rewrite firmware downloading ......................................................................

Patch Set 4:

(3 comments)

Patchset:

PS4: honestly I can't quite see the improvement because now we have dfu_flash_done and usb_dfu_status on top of the already existing dfu_state and dfu_status ... a rewrite should make it less confusing instead of even more contrived.

The patch mostly changes "things" but I'm not aware of any actual issues that are being solved here, we only have one repeatable apparently hardware related flash write issue as far as I am aware, and I'd rather not start touching a bootloader that (at least until now) did a fairly good job.

File usb/class/dfu/device/dfudf.c:

https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174/comment/2c98ad5f_910421b7... : PS4, Line 175: dfu_state = USB_DFU_STATE_DFU_DNBUSY; at least move that assignment to case USB_DFU_STATE_DFU_DNLOAD_SYNC and don't just drop old comments..

https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174/comment/3282a248_c776b2d2... : PS4, Line 272: break; why do we suddenly need superfluous break statements within else if chains?