Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30613 )
Change subject: layer23: fix rx_l1_sim_conf(): msg->l2h is NULL, use msg->l1h ......................................................................
Patch Set 1:
(1 comment)
File src/host/layer23/src/common/l1ctl.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30613/comment/aeddd14d_5c167d7e PS1, Line 742: LOGP(DL1C, LOGL_INFO, "SIM %s\n", osmo_hexdump(data, len));
Independent of this patch, I think it's really worth having a special case inside osmo_hexdump to pr […]
If the pointer is NULL, it would return an empty line, see:
https://cgit.osmocom.org/libosmocore/tree/src/utils.c#n306
Not sure if we want to change this behavior.
(The segfault was actually caused by calling msgb_l2len() while l2h is NULL)