Attention is currently required from: pespin.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/31059
)
Change subject: mgcp_client: add new clearmode codec
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File include/osmocom/mgcp_client/mgcp_client.h:
https://gerrit.osmocom.org/c/osmo-mgw/+/31059/comment/e0181d6a_1229b9e3
PS2, Line 53: CODEC_CLEARMODE = 120,
You could add a spec reference here: /* 3GPP TS 48.103
table 5.4.2.2. […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-mgw/+/31059
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I55f9fe241a405935dbedc3947b0a4f4986acd5cb
Gerrit-Change-Number: 31059
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Jan 2023 08:19:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment