Attention is currently required from: fixeria, osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/40295?usp=email )
Change subject: Introduce tests/osmo-config-merge testsuite ......................................................................
Patch Set 4:
(4 comments)
File tests/osmo-config-merge/Makefile.am:
https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/0c9de919_e0d9af3e?u... : PS4, Line 25: } >'$(srcdir)/package.m4'
What do we need package. […]
No idea tbh, copied it from tests/Makefile.am. Let me know if you know better about this stuff.
https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/10887003_0c96aef4?u... : PS4, Line 46: [ -e /proc/cpuinfo ] && cat /proc/cpuinfo
This is already done in tests/Makefile.am, so I would remove it here.
Acknowledged
https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/41c61360_43496d27?u... : PS4, Line 47: $(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS) ENABLE_URING=$(ENABLE_URING) ENABLE_URING_TESTS=$(ENABLE_URING_TESTS)
Acknowledged
https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/c125038f_544e472b?u... : PS4, Line 51: $(TESTSUITEFLAGS) ENABLE_URING=$(ENABLE_URING) ENABLE_URING_TESTS=$(ENABLE_URING_TESTS)
Acknowledged
-
pespin