Attention is currently required from: fixeria, osmith.

View Change

4 comments:

• File tests/osmo-config-merge/Makefile.am:

  • Patch Set #4, Line 25: } >'$(srcdir)/package.m4'

    What do we need package. […]

    No idea tbh, copied it from tests/Makefile.am. Let me know if you know better about this stuff.

  • Patch Set #4, Line 46: [ -e /proc/cpuinfo ] && cat /proc/cpuinfo

    This is already done in tests/Makefile.am, so I would remove it here.

    Acknowledged

  • Patch Set #4, Line 47: $(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS) ENABLE_URING=$(ENABLE_URING) ENABLE_URING_TESTS=$(ENABLE_URING_TESTS)

    ```suggestion […]

    Acknowledged

  • Patch Set #4, Line 51: $(TESTSUITEFLAGS) ENABLE_URING=$(ENABLE_URING) ENABLE_URING_TESTS=$(ENABLE_URING_TESTS)

    ```suggestion […]

    Acknowledged

To view, visit change 40295. To unsubscribe, or for help writing mail filters, visit settings.