Attention is currently required from: pespin, msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30959 ) Change subject: layer23: Add missing header dependencies to several files ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: the aim for .h files is to minimize the amount of other headers included. Instead, .c files should include .h files. In a .h file, for example, opaque struct definitions are more desirable than an include of another .h with the full struct definition. The reason is that when .h files include other .h files, a circular include dependency becomes more likely. It can "cascade" unnecessary dependencies across APIs. When we aim each .h file to remain as opaque as possible, we avoid circular dependencies. (also, includes between .h files can cause more .o files to be recompiled than necessary for small changes to .h files) So in this patch, i would re-argue every .h file where an #include is added -- it compiled before, why add #includes? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30959 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9819b12d1c24f6ee197daa887452b09418d689e8 Gerrit-Change-Number: 30959 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sun, 15 Jan 2023 23:11:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment