Attention is currently required from: pespin, msuraev.
1 comment:
Patchset:
the aim for .h files is to minimize the amount of other headers included. Instead, .c files should include .h files.
In a .h file, for example, opaque struct definitions are more desirable than an include of another .h with the full struct definition.
The reason is that when .h files include other .h files, a circular include dependency becomes more likely. It can "cascade" unnecessary dependencies across APIs. When we aim each .h file to remain as opaque as possible, we avoid circular dependencies.
(also, includes between .h files can cause more .o files to be recompiled than necessary for small changes to .h files)
So in this patch, i would re-argue every .h file where an #include is added -- it compiled before, why add #includes?
To view, visit change 30959. To unsubscribe, or for help writing mail filters, visit settings.