[L] Change in osmo-trx[master]: ms: make app configurable - gerrit-log

22 Mar 2024


      Attention is currently required from: Hoernchen, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36373?usp=email )
Change subject: ms: make app configurable
......................................................................
Patch Set 4:
(1 comment)
File Transceiver52M/ms/ms_upper.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/36373/comment/331c274e_ab0f82cf 
PS4, Line 209: 		// pow = energyDetect(sv, 20 * 4 /*sps*/);
...
This is related to the build failure, it doesn't matter right now, that code might be reintroduced a […]
I don't see how "it doesn't matter right now" is a valid argumetn for mixing differnt orthogonal topics in one patch.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36373?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ibd432f7abbd00065a59104d2c006b676d5db7b47
Gerrit-Change-Number: 36373
Gerrit-PatchSet: 4
Gerrit-Owner: Hoernchen ewild@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-Attention: Hoernchen ewild@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Fri, 22 Mar 2024 07:33:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen ewild@sysmocom.de
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment