falconia has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/38819?usp=email ) Change subject: change default no-proxy reject cause to net-fail ...................................................................... change default no-proxy reject cause to net-fail If LU has to be rejected because DGSM mechanism cannot reach the needed HLR, then returning reject cause #17 (Network Failure) is the most accurate and truthful description of what is actually happening. Reject cause #2 (IMSI unknown in HLR) is unlikely to be a good choice: in areas where regular commercial cell services are present alongside with experimental/adventurous Osmocom-based GSM networks, this reject cause is acutely dangerous as described in the previous commit, and even in areas where no regular commercial cell services are present (the presumed intended use case for DGSM), the behavior of commanding LU-failing phones "please don't ever again try to connect to ANY network until the user power-cycles you" is unlikely to be correct/desirable. If that behavior _is_ desired, it should be configured explicitly, not by default. Change-Id: I557ae1d3291066a87228b5db4f2e207ea721329c --- M src/hlr.c M tests/test_nodes.vty 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve keith: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve falconia: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/hlr.c b/src/hlr.c index 3d020d6..a900e23 100644 --- a/src/hlr.c +++ b/src/hlr.c @@ -780,7 +780,7 @@ g_hlr->mslookup.server.mdns.domain_suffix = talloc_strdup(g_hlr, OSMO_MDNS_DOMAIN_SUFFIX_DEFAULT); g_hlr->mslookup.client.mdns.domain_suffix = talloc_strdup(g_hlr, OSMO_MDNS_DOMAIN_SUFFIX_DEFAULT); g_hlr->reject_cause = GMM_CAUSE_PLMN_NOTALLOWED; - g_hlr->no_proxy_reject_cause = GMM_CAUSE_IMSI_UNKNOWN; + g_hlr->no_proxy_reject_cause = GMM_CAUSE_NET_FAIL; /* Init default (call independent) SS session guard timeout value */ g_hlr->ncss_guard_timeout = NCSS_GUARD_TIMEOUT_DEFAULT; diff --git a/tests/test_nodes.vty b/tests/test_nodes.vty index a9203b7..b7e7214 100644 --- a/tests/test_nodes.vty +++ b/tests/test_nodes.vty @@ -114,7 +114,7 @@ ... hlr reject-cause not-found plmn-not-allowed - reject-cause no-proxy imsi-unknown + reject-cause no-proxy net-fail store-imei database hlr_vty_test.db no subscriber-create-on-demand -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/38819?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I557ae1d3291066a87228b5db4f2e207ea721329c Gerrit-Change-Number: 38819 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de>