Attention is currently required from: falconia.

pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email )

Change subject: bring twrtp into libosmo-netif ......................................................................

Patch Set 5:

(2 comments)

File src/twrtp_base.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/8f2984a3_cf223b56... : PS1, Line 120: * file descriptor passing mechanism - hence twrtp layer must have a public

Can this point be marked as resolved?

Done

https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/b7b340e9_2f1ce4f5... : PS1, Line 132: * another variant of this API with that alternative behavior.

Still not sure about 3G and IuUP specifically, but more generally speaking, if some application of R […]

See 3GPP TS 25.414 clause 5.1.3.4. RTCP is optional in IuUP.

I think it's still nice to avoid creating one extra socket for each RTP flow (eg. ending up in hundreds of sockets spared, same amount of io_uring sqes being used, etc.) if not expected to be used.

So I'd really welcome possibility to pass <0 as rtcp_fd and as a result leave the iofd below as NULL.