Attention is currently required from: manawyrm, roox, laforge. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27845 ) Change subject: octoi: differentiate UNDERRUN from SUBSTITUTED in counters ...................................................................... Patch Set 1: (1 comment) File src/octoi/frame_rifo.c: https://gerrit.osmocom.org/c/osmo-e1d/+/27845/comment/757e53ef_2a772371 PS1, Line 141: if (frame_rifo_depth(rifo) == 0) { I think technically the current frame_rifo_depth is "off-by-one" in the sense that it will return 0 if the frame that's about to be read is the last one. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27845 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I5448430b09ec10a16decdfd0a4a40850fe2ed1a6 Gerrit-Change-Number: 27845 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: roox <mardnh(a)gmx.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: roox <mardnh(a)gmx.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 20 Apr 2022 12:34:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment