Attention is currently required from: osmith, fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912 )
Change subject: cbc: Test ETWS msg over CBSP
......................................................................
Patch Set 3:
(1 comment)
File cbc/BSC_ConnectionHandler.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912/comment/b2c36e63_060d…
PS3, Line 101: var template (omit) uint8_t channel_ind := omit;
If it can be uninitialized, then I think you should be
using isbound(). Otherwise it's confusing.
I gave this another try and indeed it
seems to be fine passing the optional param directly, I must have been confusing this with
another problem I had at the time. I'll change these commits to remove this extra
template variable.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie22a00120218a205db11a5622274dcc67435f5de
Gerrit-Change-Number: 28912
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 05 Aug 2022 13:47:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment