laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/31064 ) Change subject: ts_51_011: Fix bit-order in EF.VGCSS and EF.VBSS ...................................................................... ts_51_011: Fix bit-order in EF.VGCSS and EF.VBSS Those files contain a bit-mask of active group IDs stored at the respective positions in EV.VGCS and EF.VBS. However, the bit-order of each byte is reversed. Change-Id: I77674c23823aae71c9504b1a85cd75266edadc6f Related: OS#5784 --- M pySim/ts_51_011.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index bb49f13..a353101 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -714,8 +714,8 @@ def __init__(self, fid='6fb2', sfid=None, name='EF.VGCSS', size=(7, 7), desc='Voice Group Call Service Status', **kwargs): super().__init__(fid, sfid=sfid, name=name, desc=desc, size=size, **kwargs) - self._construct = BitStruct( - 'flags'/Bit[50], Padding(6, pattern=b'\xff')) + self._construct = BitsSwapped(BitStruct( + 'flags'/Bit[50], Padding(6, pattern=b'\xff'))) # TS 51.011 Section 10.3.24 class EF_eMLPP(TransparentEF): 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31064 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I77674c23823aae71c9504b1a85cd75266edadc6f Gerrit-Change-Number: 31064 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged