Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32552 ) Change subject: osmo-bts-trx: fix trx_ctrl_read_cb(): do not send CMDs twice ...................................................................... Patch Set 1: (2 comments) File src/osmo-bts-trx/trx_if.c: https://gerrit.osmocom.org/c/osmo-bts/+/32552/comment/2a61bf08_dff8a19b PS1, Line 737: what about moving "trx_ctrl_send(l1h);" here before call to trx_ctrl_rx_rsp()? this way we don't get into this kind of race condition. https://gerrit.osmocom.org/c/osmo-bts/+/32552/comment/d87a4fa9_363e5bdb PS1, Line 751: if (more_cmds) Nevermind this comment. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32552 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibdffa4644aa3a7d219452644d3e74b411734f1df Gerrit-Change-Number: 32552 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Apr 2023 23:05:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment