Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32552 )
Change subject: osmo-bts-trx: fix trx_ctrl_read_cb(): do not send CMDs twice ......................................................................
Patch Set 1:
(2 comments)
File src/osmo-bts-trx/trx_if.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32552/comment/2a61bf08_dff8a19b PS1, Line 737: what about moving "trx_ctrl_send(l1h);" here before call to trx_ctrl_rx_rsp()? this way we don't get into this kind of race condition.
https://gerrit.osmocom.org/c/osmo-bts/+/32552/comment/d87a4fa9_363e5bdb PS1, Line 751: if (more_cmds)
shouldn't this patch actually simply be here: […]
Nevermind this comment.