Attention is currently required from: Timur Davydov, pespin.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email )
Change subject: build: keep netns API public and gate features with HAVE_* ......................................................................
Patch Set 8:
(1 comment)
File src/core/netns.c:
https://gerrit.osmocom.org/c/libosmocore/+/41878/comment/e4fc1382_e69a4571?u... : PS7, Line 92: return -ENOSYS;
I'll change the fallback return code to -ENOTSUP and also add proper […]
While looking into this, I also noticed that netns.c does not actually use anything from <sys/types.h>, <sys/stat.h> or <sys/socket.h>, and that <errno.h> is included twice. These includes appear to be leftovers.
I can drop the unused headers as part of this change (or in a follow-up cleanup patch, if you prefer).