Attention is currently required from: neels.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27566 )
Change subject: library/BSSMAP_Templates: add missing LCS Client Type IE
......................................................................
Patch Set 1:
(1 comment)
File library/BSSMAP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27566/comment/e1c1b0c9_9e5f…
PS1, Line 1877: template (value) BIT4 subtype := '0000'B) := {
would it make sense to define enums for these?
Indeed it would make sense. The problem is that BSSMAP_IE_LCSClientType comes from
Ericsson's protocol modules (external deps), and somehow they prefer using BITs and
OCTs over the enumerated types. So not in this case, unfortunately :/
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27566
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5c8d6962e957d587dc4b65d08bf56bd4ef2f0d6e
Gerrit-Change-Number: 27566
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 23 Mar 2022 15:34:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment