[M] Change in osmo-bsc[master]: nokia_site: introduce hopping control for Nokia *Site - gerrit-log

13 Jan 2025

Attention is currently required from: fixeria, laforge, pespin.

csaba.sipos has posted comments on this change by csaba.sipos. (
https://gerrit.osmocom.org/c/osmo-bsc/+/39290?usp=email )

Change subject: nokia_site: introduce hopping control for Nokia *Site
......................................................................

Patch Set 7:

(2 comments)

File src/osmo-bsc/bts_nokia_site.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/74f4207a_b627ca94?usp… :
PS6, Line 1074: 
...
  this extra whitespace is probably unexpected?
Done

File src/osmo-bsc/bts_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/0a76e50d_2794f6f1?usp… :
PS6, Line 470: nokia_hopping
...
  Maybe call this part `hopping-kind` or `hopping-mode`?
Also, I don't like the choice of numeric mode […] Done

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39290?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Idb1d269d2ee80d72ede2394125e8acedf0ee8b06
Gerrit-Change-Number: 39290
Gerrit-PatchSet: 7
Gerrit-Owner: csaba.sipos &lt;metro4(a)freemail.hu&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-CC: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Comment-Date: Mon, 13 Jan 2025 15:15:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;
Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;