[S] Change in osmo-ttcn3-hacks[master]: library: RTP_Emulation: implement new RTPEM_MODE_LOOPBACK - gerrit-log

1 Sep 2023


      Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34276 )
Change subject: library: RTP_Emulation: implement new RTPEM_MODE_LOOPBACK
......................................................................
Patch Set 1:
(1 comment)
File library/RTP_Emulation.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34276/comment/d4094645_bb5d8... 
PS1, Line 100: 	var boolean g_loopback := false;
...
why aren't we simply storing RtpemMode received from the port?
We can of course improve the code further. But I am afraid I cannot put even more time into this...
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34276
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iee8f736e1eebc357fc997353ee4b629d24dc09e7
Gerrit-Change-Number: 34276
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Fri, 01 Sep 2023 20:59:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment