Attention is currently required from: osmith, laforge, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28809 )
Change subject: trxcon: rework trxcon_fsm, move into a separate file
......................................................................
Patch Set 3:
(2 comments)
File src/host/trxcon/src/l1ctl.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/28809/comment/dedce64d_aa25e407
PS3, Line 467: /* FIXME: we cannot know for sure if the given mode was actually applied.
See for instance: […]
Done
File src/host/trxcon/src/trxcon_fsm.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/28809/comment/b198da57_8cbeb213
PS3, Line 210: ");
Nice catch! Thanks!
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/28809
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ifaf63ead9dd180181358e771367b2a686ba159ca
Gerrit-Change-Number: 28809
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: osmith
osmith@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Fri, 29 Jul 2022 13:35:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith
osmith@sysmocom.de
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Gerrit-MessageType: comment