Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375 ) Change subject: pcu: TC_t3193: Fix test to properly trigger tx of last DL data block ...................................................................... Patch Set 1: Code-Review+1 (3 comments) File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375/comment/531e4be3_9f9b… PS1, Line 1878: est test https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375/comment/280b2175_4b84… PS1, Line 1880: alrady already https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375/comment/94ada739_a0cd… PS1, Line 1882: f_vty_config2(PCUVTY, {"pcu"}, "timer X2031 0"); does the timer get reset again at the beginning of tests? (probably, but just to be sure) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33375 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibd445bdd5cc1d1ffd810eea157829403b4b65f1f Gerrit-Change-Number: 33375 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Jun 2023 10:22:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment