Attention is currently required from: osmith.

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31547 )

Change subject: bssmap_handle_ass_req_ct_data: implement ......................................................................

Patch Set 2:

(3 comments)

File src/osmo-bsc/codec_pref.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/31547/comment/90e92af4_3dbb1216 PS2, Line 117: gsm0804 gsm0408, not gsm0804. 04.x is radio/Um interface, while 08.x is RAN interfaces like Abis or A.

https://gerrit.osmocom.org/c/osmo-bsc/+/31547/comment/55208cd2_be556383 PS2, Line 137: sm0804 likewise here, gsm0408. or gsm48 if you want to stay like the enum/constant values.

File src/osmo-bsc/osmo_bsc_bssap.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/31547/comment/489b903a_250a7b78 PS2, Line 677: select_codecs_data FYI, it's not really a 'codec' in the data case, but a "rate". Yes, I understand it may make sense to name it "wrong" to be consistent with other code, but just saying...