Attention is currently required from: fixeria, lynxis lazus, pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38433?usp=email )
Change subject: sgsn: Validate TLI received in RAB Ass Req
......................................................................
Patch Set 2: -Code-Review
(1 comment)
Patchset:
PS2:
while I agree decmatch is useful in several places, I believe in this specific case it is fine leavi […]
osmo-sgsn most certainly has configurable transport layer address, as we had to talk to different hNodeB with different interpretations.
`src/sgsn/sgsn_vty.c: ranap_iu_vty_init(SGSN_NODE, &g_cfg->iu.rab_assign_addr_enc);`
So if we implement tests, the tests must equally be configurable and the test case should be executed twice, using the vty to change the sgsn-side setting.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38433?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3a3699cea981caa89b30742c031d5f232418b0ee
Gerrit-Change-Number: 38433
Gerrit-PatchSet: 2
Gerrit-Owner: pespin
pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: lynxis lazus
lynxis@fe80.eu
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: lynxis lazus
lynxis@fe80.eu
Gerrit-Comment-Date: Wed, 16 Oct 2024 12:44:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge
laforge@osmocom.org
Comment-In-Reply-To: pespin
pespin@sysmocom.de