Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31056 ) Change subject: gsm_r: EF_Predefined: Decode first record different from others ...................................................................... Patch Set 2: (2 comments) File pySim/gsm_r.py: https://gerrit.osmocom.org/c/pysim/+/31056/comment/5ededd3a_bd49c57f PS2, Line 252: EF_Predefined I thought that only works for instance variables, but not for class variables? I can test, but I think I've run into problems with this at some other time. https://gerrit.osmocom.org/c/pysim/+/31056/comment/e16b8d6f_32cd1e5e PS2, Line 257: r = None In that case: What would ensure that the scope of 'r' is not just within the "if" statement but in the entire method? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31056 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib526f6c3c2ac9a945b8242e2e54536628376efc0 Gerrit-Change-Number: 31056 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Jan 2023 19:49:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment