Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31056 )

Change subject: gsm_r: EF_Predefined: Decode first record different from others ......................................................................

Patch Set 2:

(2 comments)

File pySim/gsm_r.py:

https://gerrit.osmocom.org/c/pysim/+/31056/comment/5ededd3a_bd49c57f PS2, Line 252: EF_Predefined

self

I thought that only works for instance variables, but not for class variables? I can test, but I think I've run into problems with this at some other time.

https://gerrit.osmocom.org/c/pysim/+/31056/comment/e16b8d6f_32cd1e5e PS2, Line 257: r = None

this line can be safely removed

In that case: What would ensure that the scope of 'r' is not just within the "if" statement but in the entire method?