Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40581?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: sccp: Split sccp_scoc into multiple files ...................................................................... sccp: Split sccp_scoc into multiple files The previous state was really messy with sccp_scoc.c containing lots of different not-directly-related modules, which made it very difficult to find all the parts and gasp the whole picture. It also makes it easier to extend the code in the future as we plan to be adding more features from time to time. This commit moves (splits) sccp_scoc.c + sccp_internal.h out to different modules: * sccp_user.h is added since there already existed sccp_user.c, operating on struct sccp_user. * sccp_connection.{c,h} is added to contain all the struct sccp_connection data domain logic. * sccp_scoc_fsm.{c,h} is added to have all the related FSM code self-contained in a file. * sccp_sap.c: Some code related to the SCU primitive is moved here, where it belongs. * sccp_vty: Some related vty code is moved here, where it belongs. The SCOC handling logic is kept in the sccp_scoc.c file. Some functions are properly prefixed when moved to the correct file. Change-Id: I51e9bf60bc4c4b2babd3f408daed914eaf398e82 --- M src/Makefile.am A src/sccp_connection.c A src/sccp_connection.h M src/sccp_helpers.c M src/sccp_internal.h M src/sccp_lbcs.c M src/sccp_sap.c M src/sccp_sclc.c M src/sccp_scmg.c M src/sccp_scoc.c A src/sccp_scoc_fsm.c A src/sccp_scoc_fsm.h M src/sccp_user.c A src/sccp_user.h M src/sccp_vty.c M src/ss7.c 16 files changed, 1,403 insertions(+), 1,236 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/81/40581/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40581?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I51e9bf60bc4c4b2babd3f408daed914eaf398e82 Gerrit-Change-Number: 40581 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de>