Attention is currently required from: fixeria. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/37558?usp=email ) Change subject: codec: add osmo_hr_sid_classify() ...................................................................... Patch Set 2: (2 comments) File src/codec/hr_sid_class.c: https://gerrit.osmocom.org/c/libosmocore/+/37558/comment/817ad5f5_40c36ba5 PS2, Line 35: for (; byte; byte >>= 1) { Thanks for the recommendation - I will implement it in the next revision of this patch. https://gerrit.osmocom.org/c/libosmocore/+/37558/comment/8839cf1e_7a40cc4c PS2, Line 144: class1_ones = sid_field_ones - class2_ones; No, `class2_ones` can never be greater than `sid_field_ones` because the definition of SID field for HRv1 (GSM 06.22) includes all 17 class 2 bits plus some (62 out of 95) class 1 bits. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37558?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5f4eb65379646125b966cf182775b6e9348900bd Gerrit-Change-Number: 37558 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Jul 2024 08:12:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment