Attention is currently required from: jolly, laforge, osmith, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35583?usp=email )
Change subject: mobile: implement sending CSD data over UNIX socket ......................................................................
Patch Set 6:
(2 comments)
File src/host/layer23/src/mobile/tch_data_sock.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/35583/comment/e235081d_97ceac1b PS5, Line 168: osmo_fd_read_disable(&state->listen_bfd);
You disable read of socket listening fd. […]
Ack, thanks. Fixed in the next patchset revision.
File src/host/layer23/src/mobile/tch_data_sock.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/35583/comment/ecfa861f_539b350b PS6, Line 111: osmo_fd_write_disable(bfd);
afaiu this should only be done when llist becomes empty, aka after te "while"
Ack. We also leak `msg` here... Fixed in the next patchset revision.
-
fixeria