Attention is currently required from: jolly, laforge, osmith, pespin.

View Change

2 comments:

• File src/host/layer23/src/mobile/tch_data_sock.c:

  • Patch Set #5, Line 168: osmo_fd_read_disable(&state->listen_bfd);

    You disable read of socket listening fd. […]

    Ack, thanks. Fixed in the next patchset revision.

• File src/host/layer23/src/mobile/tch_data_sock.c:

  • Patch Set #6, Line 111: osmo_fd_write_disable(bfd);

    afaiu this should only be done when llist becomes empty, aka after te "while"

    Ack. We also leak `msg` here... Fixed in the next patchset revision.

To view, visit change 35583. To unsubscribe, or for help writing mail filters, visit settings.