Attention is currently required from: pespin.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32236 )

Change subject: Merge gsm_network into gsm_bts_sm and place gsm_bts under it ......................................................................

Patch Set 5: Code-Review+1

(4 comments)

File src/common/bts.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32236/comment/4964755f_ae6cc6c6 PS4, Line 406: g_bts_sm->num_bts++;

This change would not be part of this patch however, I'll fix it in a followup patch.

Done https://gerrit.osmocom.org/c/osmo-bts/+/32262.

File src/common/bts_sm.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32236/comment/cd291f02_0b2c12e8 PS4, Line 37: talloc_free

I prefer doing it this way in order to control the order of stuff being freed.

Done

File src/common/oml.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32236/comment/7be6a4d1_87af8346 PS4, Line 154: if (!bts) {

Ack

Done

File src/common/pcu_sock.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32236/comment/562cbc93_3529b683 PS4, Line 957: struct gsm_bts_sm *bts_sm

Yes we could, I'm not sure if it makes sense doing it in this commit or not, I simply changed the mi […]

Done