Attention is currently required from: pespin.

Patch set 5:Code-Review +1

View Change

4 comments:

• File src/common/bts.c:

  • Patch Set #4, Line 406: g_bts_sm->num_bts++;

    This change would not be part of this patch however, I'll fix it in a followup patch.

    Done https://gerrit.osmocom.org/c/osmo-bts/+/32262.

• File src/common/bts_sm.c:

  • Patch Set #4, Line 37: talloc_free

    I prefer doing it this way in order to control the order of stuff being freed.

    Done

• File src/common/oml.c:

  • Patch Set #4, Line 154: if (!bts) {

    Ack

    Done

• File src/common/pcu_sock.c:

  • Patch Set #4, Line 957: struct gsm_bts_sm *bts_sm

    Yes we could, I'm not sure if it makes sense doing it in this commit or not, I simply changed the mi […]

    Done

To view, visit change 32236. To unsubscribe, or for help writing mail filters, visit settings.