pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29552 )

Change subject: vty: 'hopping arfcn add': succeed if adding arfcn already in set ......................................................................

vty: 'hopping arfcn add': succeed if adding arfcn already in set

There's no need to fail, simply make it a noop in that case, everything's fine and everybody is happy (specially when using CTRL command "apply-config-file" to load a .cfg file containing modifications.

Related: SYS#6138 (cherry picked from Change-Id Ia4e70d20d48a28c46a21dd10358577e5c798744c) Change-Id: I1f90f76653a8c4f76d1200ba370dc8fe2a568949 --- M src/osmo-bsc/bts_trx_vty.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/52/29552/1

diff --git a/src/osmo-bsc/bts_trx_vty.c b/src/osmo-bsc/bts_trx_vty.c index 9cf128e..920df16 100644 --- a/src/osmo-bsc/bts_trx_vty.c +++ b/src/osmo-bsc/bts_trx_vty.c @@ -401,7 +401,7 @@

if (bitvec_get_bit_pos(&ts->hopping.arfcns, arfcn) == ONE) { vty_out(vty, "%% ARFCN %" PRIu16 " is already set%s", arfcn, VTY_NEWLINE); - return CMD_WARNING; + return CMD_SUCCESS; }

bitvec_set_bit_pos(&ts->hopping.arfcns, arfcn, 1);