Attention is currently required from: neels, laforge, pespin, fixeria. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29788 ) Change subject: Add BTS setup ramping to prevent BSC overloading ...................................................................... Patch Set 16: (3 comments) Patchset: PS16: As long we don't check the state of the NM objects, we might end up sending events to the NM states in the wrong state. File src/osmo-bsc/bts_setup_ramp.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/47e61914_d49c6582 PS16, Line 40: nm_fsm_dispatch_all(bts, NM_EV_RAMP_GO, NULL); As long we don't check the state here of the NM objects, we might end up sending events to the NM states in the wrong state. File src/osmo-bsc/nm_bb_transc_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/b045fbe8_0d440d21 PS16, Line 347: case NM_BB_TRANSC_ST_OP_DISABLED_DEPENDENCY: As long we don't check the state in btrs_setup_ram.c:40 of the NM objects, we might end up sending events to the NM states in the wrong state. https://gerrit.osmocom.org/c/osmo-bsc/+/29788/16/src/osmo-bsc/bts_setup_ram… -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id56dde6d58f3d0d20352f6c306598d2cccc6345d Gerrit-Change-Number: 29788 Gerrit-PatchSet: 16 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Nov 2022 10:54:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment