Attention is currently required from: neels, laforge, pespin, fixeria. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29788 )

Change subject: Add BTS setup ramping to prevent BSC overloading ......................................................................

Patch Set 16:

(3 comments)

Patchset:

PS16:

I don't get why did you move the stuff to allstate again despite I explicitly told you not to do tha […]

As long we don't check the state of the NM objects, we might end up sending events to the NM states in the wrong state.

File src/osmo-bsc/bts_setup_ramp.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/47e61914_d49c6582 PS16, Line 40: nm_fsm_dispatch_all(bts, NM_EV_RAMP_GO, NULL); As long we don't check the state here of the NM objects, we might end up sending events to the NM states in the wrong state.

File src/osmo-bsc/nm_bb_transc_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/b045fbe8_0d440d21 PS16, Line 347: case NM_BB_TRANSC_ST_OP_DISABLED_DEPENDENCY:

I'm still not getting why you keep putting this in the allstate. […]

As long we don't check the state in btrs_setup_ram.c:40 of the NM objects, we might end up sending events to the NM states in the wrong state.

https://gerrit.osmocom.org/c/osmo-bsc/+/29788/16/src/osmo-bsc/bts_setup_ramp...