Change in osmo-msc[master]: Introduce libsmpputil - gerrit-log

1 Aug 2022


      Attention is currently required from: pespin, msuraev.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28844 )
Change subject: Introduce libsmpputil
......................................................................
Patch Set 7:
(1 comment)
File src/utils/Makefile.am:
https://gerrit.osmocom.org/c/osmo-msc/+/28844/comment/61592573_180398a3 
PS2, Line 32: 	$(top_srcdir)/src/libmsc/smpp_smsc.h \
...
Given it's internal build-time optional library I don't think it's worth the effort.
it doesn't need to be a new SMPP_UTIL_HEADERS, but I actually think it would even make sense to move it to a separate sub-directory like src/smpp/ or the like.  I'd agree with pespin that it's best to somehow have a logical grouping for both source and header files, so it's clear which belongs where.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28844
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I61910651bc7c188dc2fb67d96189a66a47e7e8fb
Gerrit-Change-Number: 28844
Gerrit-PatchSet: 7
Gerrit-Owner: msuraev msuraev@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: msuraev msuraev@sysmocom.de
Gerrit-Comment-Date: Mon, 01 Aug 2022 10:00:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de
Comment-In-Reply-To: msuraev msuraev@sysmocom.de
Gerrit-MessageType: comment