[S] Change in osmo-sgsn[master]: GTP: CreatePDPContext: only use IMEISV IE when IMEISV is known - gerrit-log

16 Oct 2024


      Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/38444?usp=email )
Change subject: GTP: CreatePDPContext: only use IMEISV IE when IMEISV is known
......................................................................
Patch Set 1:
(1 comment)
File src/sgsn/sgsn_libgtp.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/38444/comment/94ee6d4b_22002bdc?usp... :
PS1, Line 303: 	if (mmctx->imei[0] != 0x00) {
Can't an IMEI have a 0 digit?
If it's a string, then use '\0' to clarify.
In any case, this is really confusing, some comment explaining this may be welcome.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38444?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I812af1e702e77214244f32ae65663c1a03b23962
Gerrit-Change-Number: 38444
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus lynxis@fe80.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: lynxis lazus lynxis@fe80.eu
Gerrit-Comment-Date: Wed, 16 Oct 2024 18:05:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No