Attention is currently required from: fixeria, pespin.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006?usp=email )
Change subject: s1ap_proxy: Add support for S1 HANDOVER procedure ......................................................................
Patch Set 4:
(7 comments)
Commit Message:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/58f0d663_677b6... : PS3, Line 9: The procedure is uses two parts:
"is uses" is wrong.
Done
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/745de4ec_08aca... : PS3, Line 11: * Peperation of handover on the source eNB
Preparation?
Done
File include/s1gw_metrics.hrl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/f94611df_b34b8... : PS1, Line 36: handover_rsp
Let's use `handover_req_ack` here.
Done
File src/s1ap_proxy.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/37135982_e949a... : PS1, Line 640: PATH SWITCH
These PDUs are not implemented yet, so let's keep the TODO comments for them.
Done
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/05f224be_106dc... : PS1, Line 1092: 'transportLayerAddress' = TLA_In, :
cosmetic: formatting issues
Done
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/d4abfba3_35937... : PS1, Line 1113: 'transportLayerAddress' = TLA_In, :
cosmetic: formatting issues
Done
File src/s1ap_proxy.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/d3de6e92_da1ae... : PS3, Line 638: {forward, S1};
%% forward as-is, there's nothing to patch
Done
-
jolly