laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/30439 ) Change subject: pySim-trace: Fix missing MANAGE CHANNEL decode ...................................................................... pySim-trace: Fix missing MANAGE CHANNEL decode old output: 00 MANAGE CHANNEL 01 9110 new output: 00 MANAGE CHANNEL 01 9110 {'mode': 'open_channel', 'created_channel': 1} Change-Id: Iac5b24c14d2b68d526ab347462b72548b8731b30 --- M pySim/apdu/ts_102_221.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/pySim/apdu/ts_102_221.py b/pySim/apdu/ts_102_221.py index fb2f375..ea45602 100644 --- a/pySim/apdu/ts_102_221.py +++ b/pySim/apdu/ts_102_221.py @@ -393,10 +393,12 @@ manage_channel = rs.get_lchan_by_cla(self.cla) manage_channel.add_lchan(created_channel_nr) self.col_id = '%02u' % created_channel_nr + return {'mode': mode, 'created_channel': created_channel_nr } elif mode == 'close_channel': closed_channel_nr = self.cmd_dict['p2'] rs.del_lchan(closed_channel_nr) self.col_id = '%02u' % closed_channel_nr + return {'mode': mode, 'closed_channel': closed_channel_nr } else: raise ValueError('Unsupported MANAGE CHANNEL P1=%02X' % self.p1) 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/30439 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iac5b24c14d2b68d526ab347462b72548b8731b30 Gerrit-Change-Number: 30439 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jtavares <jtavares(a)kvh.com> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged